Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2554113002: Deprecate UnthrottledThreadTimer. (Closed)
Patch Set: Move forgotten timer too Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.h ('k') | third_party/WebKit/Source/platform/Timer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index d03da2e9ca79091341d7e82c4d61eac99a70a038..ececc0032f57cb4c49c5cadaef855936f65caa32 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -362,15 +362,27 @@ HTMLMediaElement::HTMLMediaElement(const QualifiedName& tagName,
Document& document)
: HTMLElement(tagName, document),
SuspendableObject(&document),
- m_loadTimer(this, &HTMLMediaElement::loadTimerFired),
- m_progressEventTimer(this, &HTMLMediaElement::progressEventTimerFired),
- m_playbackProgressTimer(this,
- &HTMLMediaElement::playbackProgressTimerFired),
- m_audioTracksTimer(this, &HTMLMediaElement::audioTracksTimerFired),
+ m_loadTimer(TaskRunnerHelper::get(TaskType::Unthrottled, &document),
+ this,
+ &HTMLMediaElement::loadTimerFired),
+ m_progressEventTimer(
+ TaskRunnerHelper::get(TaskType::Unthrottled, &document),
+ this,
+ &HTMLMediaElement::progressEventTimerFired),
+ m_playbackProgressTimer(
+ TaskRunnerHelper::get(TaskType::Unthrottled, &document),
+ this,
+ &HTMLMediaElement::playbackProgressTimerFired),
+ m_audioTracksTimer(
+ TaskRunnerHelper::get(TaskType::Unthrottled, &document),
+ this,
+ &HTMLMediaElement::audioTracksTimerFired),
m_viewportFillDebouncerTimer(
+ TaskRunnerHelper::get(TaskType::Unthrottled, &document),
this,
&HTMLMediaElement::viewportFillDebouncerTimerFired),
m_checkViewportIntersectionTimer(
+ TaskRunnerHelper::get(TaskType::Unthrottled, &document),
this,
&HTMLMediaElement::checkViewportIntersectionTimerFired),
m_playedTimeRanges(),
@@ -466,6 +478,19 @@ void HTMLMediaElement::dispose() {
void HTMLMediaElement::didMoveToNewDocument(Document& oldDocument) {
BLINK_MEDIA_LOG << "didMoveToNewDocument(" << (void*)this << ")";
+ m_loadTimer.moveToNewTaskRunner(
+ TaskRunnerHelper::get(TaskType::Unthrottled, &document()));
+ m_progressEventTimer.moveToNewTaskRunner(
+ TaskRunnerHelper::get(TaskType::Unthrottled, &document()));
+ m_playbackProgressTimer.moveToNewTaskRunner(
+ TaskRunnerHelper::get(TaskType::Unthrottled, &document()));
+ m_audioTracksTimer.moveToNewTaskRunner(
+ TaskRunnerHelper::get(TaskType::Unthrottled, &document()));
+ m_viewportFillDebouncerTimer.moveToNewTaskRunner(
+ TaskRunnerHelper::get(TaskType::Unthrottled, &document()));
+ m_checkViewportIntersectionTimer.moveToNewTaskRunner(
+ TaskRunnerHelper::get(TaskType::Unthrottled, &document()));
+
m_autoplayUmaHelper->didMoveToNewDocument(oldDocument);
// If any experiment is enabled, then we want to enable a user gesture by
// default, otherwise the experiment does nothing.
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.h ('k') | third_party/WebKit/Source/platform/Timer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698