Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 25541005: Telemetry: document.documentElement.scrollTop/Left is zero (Closed)

Created:
7 years, 2 months ago by tonikitoo_
Modified:
7 years, 2 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Telemetry: document.documentElement.scrollTop/Left is zero In order for bug 157855 to get fixed without breaking a related telemetry unit test (page/actions/scroll_unittest.py), this patch changes the way scrollTop property is checked: it uses an annotation similar to the how real world WebPages do, where both documentElement and body is checked for cross browser compatibility. Once bug 157855, it should be encouraged to adopt scrollTop of documentElement only. BUG=302707 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226872

Patch Set 1 : document.documentElement.scrollTop/Left is zero - Telemetry preparation. #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/telemetry/telemetry/page/actions/scroll_unittest.py View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tonyg
lgtm
7 years, 2 months ago (2013-10-03 03:11:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a1.gomes@sisa.samsung.com/25541005/2001
7 years, 2 months ago (2013-10-03 13:11:09 UTC) #2
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=28662
7 years, 2 months ago (2013-10-03 13:32:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a1.gomes@sisa.samsung.com/25541005/11001
7 years, 2 months ago (2013-10-03 13:46:26 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=28671
7 years, 2 months ago (2013-10-03 14:05:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a1.gomes@sisa.samsung.com/25541005/11001
7 years, 2 months ago (2013-10-03 20:07:46 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-03 22:25:36 UTC) #7
Message was sent while issue was closed.
Change committed as 226872

Powered by Google App Engine
This is Rietveld 408576698