Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Issue 25541003: Add column getter to CpuProfileNode (Closed)

Created:
7 years, 2 months ago by yurys
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add column getter to CpuProfileNode CpuProfileNode currently exposes only line number which is not enough for the cases when there is more than one function on the same line. This change exposes column number on CpuProfileNode. BUG=302537 R=jkummerow@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17142

Patch Set 1 #

Patch Set 2 : Added test #

Patch Set 3 : Comment addressed #

Patch Set 4 : Also check script id in the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -13 lines) Patch
M include/v8-profiler.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/cpu-profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/cpu-profiler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/log.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/log.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/profile-generator.h View 1 2 4 chunks +7 lines, -2 lines 0 comments Download
M src/profile-generator.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M src/profile-generator-inl.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
Yang, can you have a look?
7 years, 2 months ago (2013-10-02 08:17:12 UTC) #1
loislo
lgtm but I'd land not necessary cosmetic changes as a separate patch.
7 years, 2 months ago (2013-10-02 08:21:21 UTC) #2
yurys
On 2013/10/02 08:21:21, loislo wrote: > lgtm but I'd land not necessary cosmetic changes as ...
7 years, 2 months ago (2013-10-02 08:52:24 UTC) #3
yurys
Jakob: can you give OWNER's stamp for this while Yang is out of office please?
7 years, 2 months ago (2013-10-04 09:36:44 UTC) #4
Jakob Kummerow
lgtm
7 years, 2 months ago (2013-10-04 09:57:24 UTC) #5
yurys
7 years, 2 months ago (2013-10-10 13:15:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r17142 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698