Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Issue 2554093004: [DevTools] proper cleanup BlackboxManager on targetRemoved (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @implements {SDK.TargetManager.Observer} 5 * @implements {SDK.TargetManager.Observer}
6 * @unrestricted 6 * @unrestricted
7 */ 7 */
8 Bindings.BlackboxManager = class { 8 Bindings.BlackboxManager = class {
9 /** 9 /**
10 * @param {!Bindings.DebuggerWorkspaceBinding} debuggerWorkspaceBinding 10 * @param {!Bindings.DebuggerWorkspaceBinding} debuggerWorkspaceBinding
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 var debuggerModel = SDK.DebuggerModel.fromTarget(target); 51 var debuggerModel = SDK.DebuggerModel.fromTarget(target);
52 if (debuggerModel) 52 if (debuggerModel)
53 this._setBlackboxPatterns(debuggerModel); 53 this._setBlackboxPatterns(debuggerModel);
54 } 54 }
55 55
56 /** 56 /**
57 * @override 57 * @override
58 * @param {!SDK.Target} target 58 * @param {!SDK.Target} target
59 */ 59 */
60 targetRemoved(target) { 60 targetRemoved(target) {
61 var debuggerModel = SDK.DebuggerModel.fromTarget(target);
62 if (debuggerModel) {
63 this._debuggerModelData.delete(debuggerModel);
64 this._isBlackboxedURLCache.clear();
65 }
61 } 66 }
62 67
63 /** 68 /**
64 * @param {!SDK.DebuggerModel} debuggerModel 69 * @param {!SDK.DebuggerModel} debuggerModel
65 * @return {!Promise<boolean>} 70 * @return {!Promise<boolean>}
66 */ 71 */
67 _setBlackboxPatterns(debuggerModel) { 72 _setBlackboxPatterns(debuggerModel) {
68 var regexPatterns = Common.moduleSetting('skipStackFramesPattern').getAsArra y(); 73 var regexPatterns = Common.moduleSetting('skipStackFramesPattern').getAsArra y();
69 var patterns = /** @type {!Array<string>} */ ([]); 74 var patterns = /** @type {!Array<string>} */ ([]);
70 for (var item of regexPatterns) { 75 for (var item of regexPatterns) {
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 if (scheme === 'chrome-extension') 423 if (scheme === 'chrome-extension')
419 prefix += parsedURL.host + '\\b'; 424 prefix += parsedURL.host + '\\b';
420 prefix += '.*'; 425 prefix += '.*';
421 } 426 }
422 return prefix + name.escapeForRegExp() + (url.endsWith(name) ? '$' : '\\b'); 427 return prefix + name.escapeForRegExp() + (url.endsWith(name) ? '$' : '\\b');
423 } 428 }
424 }; 429 };
425 430
426 /** @type {!Bindings.BlackboxManager} */ 431 /** @type {!Bindings.BlackboxManager} */
427 Bindings.blackboxManager; 432 Bindings.blackboxManager;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698