Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2554093004: [DevTools] proper cleanup BlackboxManager on targetRemoved (Closed)

Created:
4 years ago by kozy
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] proper cleanup BlackboxManager on targetRemoved BUG=chromium:671479 R=lushnikov@chromium.org Committed: https://crrev.com/422ebff9ec33ed3a9219810ba899d7e33799d743 Cr-Commit-Position: refs/heads/master@{#436871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kozy
Andrey, please take a look!
4 years ago (2016-12-07 01:57:07 UTC) #1
lushnikov
lgtm
4 years ago (2016-12-07 03:10:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554093004/1
4 years ago (2016-12-07 03:10:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 05:33:25 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-07 05:34:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/422ebff9ec33ed3a9219810ba899d7e33799d743
Cr-Commit-Position: refs/heads/master@{#436871}

Powered by Google App Engine
This is Rietveld 408576698