Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2554093003: Revert of [Devtools] Fixed flakey network-columns-sorted.html test (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
Reviewers:
dgozman, lushnikov, allada
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Devtools] Fixed flakey network-columns-sorted.html test (patchset #1 id:1 of https://codereview.chromium.org/2542553002/ ) Reason for revert: Broke timeline tree view. BUG=671487 Original issue's description: > [Devtools] Fixed flakey network-columns-sorted.html test > > Fixes recently added flakey test. > > R=dgozman,lushnikov > BUG=669753 > > Committed: https://crrev.com/82ef6cfd810f4acb06a7aafc598fefc806773b12 > Cr-Commit-Position: refs/heads/master@{#435391} TBR=dgozman@chromium.org,lushnikov@chromium.org,allada@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=669753 NOTRY=true Committed: https://crrev.com/273f0908bb5fe23363e686201ac0e6c86d0601a7 Cr-Commit-Position: refs/heads/master@{#436674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted.html View 3 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
alph
Created Revert of [Devtools] Fixed flakey network-columns-sorted.html test
4 years ago (2016-12-06 18:56:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554093003/1
4 years ago (2016-12-06 18:58:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 19:07:32 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-06 19:09:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/273f0908bb5fe23363e686201ac0e6c86d0601a7
Cr-Commit-Position: refs/heads/master@{#436674}

Powered by Google App Engine
This is Rietveld 408576698