Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2554083003: gn: Fix integer subtraction. (Closed)

Created:
4 years ago by viettrungluu
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Fix integer subtraction. Who knew that gn files even support an integer type! Committed: https://crrev.com/4c53f32fe75ebc06a2f9184e07319acce8c9583d Cr-Commit-Position: refs/heads/master@{#436677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M tools/gn/operators.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/operators_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
viettrungluu
4 years ago (2016-12-06 18:36:56 UTC) #3
brettw
lgtm
4 years ago (2016-12-06 18:43:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554083003/1
4 years ago (2016-12-06 18:50:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 19:10:30 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-06 19:12:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c53f32fe75ebc06a2f9184e07319acce8c9583d
Cr-Commit-Position: refs/heads/master@{#436677}

Powered by Google App Engine
This is Rietveld 408576698