Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 255403008: Fix miscompilation of NULL check. (Closed)

Created:
6 years, 8 months ago by jbauman
Modified:
6 years, 8 months ago
Reviewers:
jschuh, vmiura
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Fix miscompilation of NULL check. The NULL check seems to be accidentally compiled out, so work around that by dereferencing the same datatype through a volatile pointer. BUG=361936 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266053

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M gpu/command_buffer/client/cmd_buffer_helper.h View 1 3 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jbauman
6 years, 8 months ago (2014-04-24 18:56:14 UTC) #1
jschuh
Lgtm as a workaround, but the more I think about it the more this seems ...
6 years, 8 months ago (2014-04-24 21:26:41 UTC) #2
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 8 months ago (2014-04-24 21:29:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/255403008/20001
6 years, 8 months ago (2014-04-24 21:43:38 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:51:00 UTC) #5
Message was sent while issue was closed.
Change committed as 266053

Powered by Google App Engine
This is Rietveld 408576698