Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2554023002: [wasm] Skip flaky asm-wasm-{switch,expr} on gc-stress (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
Michael Achenbach
CC:
bradnelson, titzer, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Skip flaky asm-wasm-{switch,expr} on gc-stress BUG=v8:5716 R=machenbach@chromium.org NOTRY=true CC=titzer@chromium.org, bradnelson@chromium.org Committed: https://crrev.com/68624259e61b88ece298c4c6c66df2c3d40e82af Cr-Commit-Position: refs/heads/master@{#41517}

Patch Set 1 #

Patch Set 2 : Fix bug number #

Total comments: 1

Patch Set 3 : Also include asm-wasm-expr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Clemens Hammacher
4 years ago (2016-12-06 11:56:57 UTC) #1
Michael Achenbach
lgtm with comment https://codereview.chromium.org/2554023002/diff/20001/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/2554023002/diff/20001/test/mjsunit/mjsunit.status#newcode250 test/mjsunit/mjsunit.status:250: 'wasm/asm-wasm-switch': [SKIP], The second link pointed ...
4 years ago (2016-12-06 11:58:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554023002/40001
4 years ago (2016-12-06 12:01:45 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-06 12:03:22 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-06 12:03:36 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/68624259e61b88ece298c4c6c66df2c3d40e82af
Cr-Commit-Position: refs/heads/master@{#41517}

Powered by Google App Engine
This is Rietveld 408576698