Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2554013002: Revert of Create JSPromise (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, adamk
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Create JSPromise (patchset #16 id:300001 of https://codereview.chromium.org/2536463002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11861 See: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > Object > -- New JSObject for promises: JSPromise > > Builtins > -- PromiseThen TFJ > -- PromiseCreateAndSet TFJ for internal use > -- PerformPromiseThen TFJ for internal use > -- PromiseInit for initial promise setup > -- SpeciesConstructor for use in PromiseThen > -- ThrowIfNotJSReceiver for use in SpeciesConstructor > -- AppendPromiseCallback to update FixedArray with new callback > -- InternalPerformPromiseThen > > Promises.js > -- Cleanup unused symbols > -- Remove PerformPromiseThen > -- Remove PromiseThen > -- Remove PromiseSet > -- Remove PromiseAttachCallbacks > > Runtime > -- PromiseSet to set promise inobject values > -- Refactor functions to use FixedArrays for callbacks instead of > JSArray > -- Runtime_PromiseStatus to return promise status > -- Runtime_PromiseResult to return promise result > -- Runtime_PromiseDeferred to return deferred attached to promise > -- Runtime_PromiseRejectReactions to return reject reactions attached > to promise > > This CL results in a 13.07% improvement in the promises benchmark > (over 5 runs). > > BUG=v8:5343 > > Committed: https://crrev.com/30b564c76f490f8f6b311a74b25b26cf0a96be2d > Cr-Commit-Position: refs/heads/master@{#41503} TBR=bmeurer@chromium.org,jgruber@chromium.org,caitp@igalia.com,gsathya@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5343 Committed: https://crrev.com/4c7cccf9f40c063e2d6410fc35664a0efd1acb46 Cr-Commit-Position: refs/heads/master@{#41512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -747 lines) Patch
M src/bootstrapper.cc View 3 chunks +3 lines, -22 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/builtins/builtins-promise.cc View 7 chunks +20 lines, -444 lines 0 comments Download
M src/contexts.h View 1 chunk +54 lines, -61 lines 0 comments Download
M src/debug/mirrors.js View 3 chunks +4 lines, -2 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +18 lines, -9 lines 0 comments Download
M src/js/async-await.js View 4 chunks +3 lines, -2 lines 0 comments Download
M src/js/promise.js View 21 chunks +146 lines, -23 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -35 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/objects-debug.cc View 4 chunks +3 lines, -18 lines 0 comments Download
M src/objects-inl.h View 4 chunks +2 lines, -7 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +1 line, -11 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/runtime/runtime-debug.cc View 3 chunks +28 lines, -3 lines 0 comments Download
M src/runtime/runtime-promise.cc View 5 chunks +20 lines, -88 lines 0 comments Download
M test/cctest/test-inobject-slack-tracking.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
Created Revert of Create JSPromise
4 years ago (2016-12-06 11:18:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554013002/1
4 years ago (2016-12-06 11:18:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 11:18:46 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-06 11:19:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c7cccf9f40c063e2d6410fc35664a0efd1acb46
Cr-Commit-Position: refs/heads/master@{#41512}

Powered by Google App Engine
This is Rietveld 408576698