Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3041)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2554003003: Log NTP launch time until user can do a search. (Closed)
Patch Set: Address review comments from bauerb. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index fff472998ace79d487491ea8ac7047465fc557c9..0437008f11f8f042b893d6401776cb5e361825ee 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -42,6 +42,7 @@ import org.chromium.base.Callback;
import org.chromium.base.Log;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;
import org.chromium.chrome.browser.favicon.FaviconHelper.IconAvailabilityCallback;
import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;
@@ -106,6 +107,7 @@ public class NewTabPageView extends FrameLayout
private OnSearchBoxScrollListener mSearchBoxScrollListener;
+ private ChromeActivity mActivity;
private NewTabPageManager mManager;
private UiConfig mUiConfig;
private MostVisitedDesign mMostVisitedDesign;
@@ -320,6 +322,7 @@ public class NewTabPageView extends FrameLayout
*/
public void initialize(
NewTabPageManager manager, Tab tab, boolean searchProviderHasLogo, int scrollPosition) {
+ mActivity = tab.getActivity();
mManager = manager;
mUiConfig = new UiConfig(this);
ViewStub stub = (ViewStub) findViewById(R.id.new_tab_page_layout_stub);
@@ -870,6 +873,7 @@ public class NewTabPageView extends FrameLayout
if (mFirstShow) {
loadTaskCompleted();
mFirstShow = false;
+ NewTabPageUma.recordSearchAvailableLoadTime(mActivity);
} else {
// Trigger a scroll update when reattaching the window to signal the toolbar that
// it needs to reset the NTP state.

Powered by Google App Engine
This is Rietveld 408576698