Issue 25540002: Remove empty RenderMediaControls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25540002: Remove empty RenderMediaControls (Closed)

Created:
7 years, 2 months ago by philipj_slow

Modified:
7 years, 2 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, feature-media-reviews_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
https://chromium.googlesource.com/chromium/blink.git@npr

Visibility:
Public.

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -86 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	Source/core/rendering/RenderMediaControls.h	View	1 chunk	+0 lines, -48 lines	0 comments	Download
D	Source/core/rendering/RenderMediaControls.cpp	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	Source/core/rendering/RenderThemeChromiumMac.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

philipj_slow

I can do the renaming of RenderMediaControlsChromium to RenderMediaControls in this commit or a separate ...

7 years, 2 months ago (2013-10-01 14:38:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/25540002/1

7 years, 2 months ago (2013-10-01 19:39:08 UTC) #4

Message was sent while issue was closed.

Change committed as 158658