Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2553973003: [ObjC ARC] Converts ios/chrome/browser/native_app_launcher:unit_tests to ARC.Automatically genera… (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
Reviewers:
lpromero
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/native_app_launcher:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/e568eb61e84c06c32f82b06914a23342a0a49373 Cr-Commit-Position: refs/heads/master@{#436633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ios/chrome/browser/native_app_launcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/native_app_infobar_controller_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/native_app_infobar_delegate_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
stkhapugin
PTAL and check CQ if lgty. Passed downstream tests.
4 years ago (2016-12-06 17:29:06 UTC) #4
lpromero
lgtm
4 years ago (2016-12-06 17:32:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553973003/1
4 years ago (2016-12-06 17:33:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 17:49:37 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-06 17:52:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e568eb61e84c06c32f82b06914a23342a0a49373
Cr-Commit-Position: refs/heads/master@{#436633}

Powered by Google App Engine
This is Rietveld 408576698