Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2553963003: [wasm][asm.js] Turning on asm.js->wasm when ignition_staging is on. (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Turning on asm.js->wasm when ignition_staging is on. BUG=v8:4203 R=danno@chromium.org,titzer@chromium.org,rmcilroy@chromium.org Committed: https://crrev.com/3e8a67e5406be46e971908d69af93bf92b6ff980 Cr-Commit-Position: refs/heads/master@{#41515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
bradn
4 years ago (2016-12-06 10:30:27 UTC) #4
titzer
lgtm but deferring to Ross.
4 years ago (2016-12-06 10:33:37 UTC) #5
Benedikt Meurer
LGTM! SHip it!
4 years ago (2016-12-06 10:37:13 UTC) #7
rmcilroy
LGTM!! Ship it!
4 years ago (2016-12-06 10:56:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553963003/1
4 years ago (2016-12-06 11:34:52 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 11:36:50 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-06 11:37:07 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e8a67e5406be46e971908d69af93bf92b6ff980
Cr-Commit-Position: refs/heads/master@{#41515}

Powered by Google App Engine
This is Rietveld 408576698