Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years ago by bradnelson Modified:
4 years ago Reviewers:
Benedikt Meurer, titzer, danno, rmcilroy, bradn CC:
v8-reviews_googlegroups.com, Michael Hablich Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm][asm.js] Turning on asm.js->wasm when ignition_staging is on.
BUG=v8:4203
R=danno@chromium.org,titzer@chromium.org,rmcilroy@chromium.org
Committed: https://crrev.com/3e8a67e5406be46e971908d69af93bf92b6ff980
Cr-Commit-Position: refs/heads/master@{#41515}
Patch Set 1 #
Created: 4 years ago
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bradnelson@google.com changed reviewers: + bradnelson@google.com
lgtm but deferring to Ross.
bmeurer@chromium.org changed reviewers: + bmeurer@chromium.org
LGTM! SHip it!
LGTM!! Ship it!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by danno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481024085020650, "parent_rev":
"d27176b19c77abed6bb15c2c5e001429fc8e95de", "commit_rev":
"dc6f7b770623c1d991d8dea2af9174c0ef3e2ca9"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [wasm][asm.js] Turning on asm.js->wasm when ignition_staging is on. BUG=v8:4203 R=danno@chromium.org,titzer@chromium.org,rmcilroy@chromium.org ========== to ========== [wasm][asm.js] Turning on asm.js->wasm when ignition_staging is on. BUG=v8:4203 R=danno@chromium.org,titzer@chromium.org,rmcilroy@chromium.org Committed: https://crrev.com/3e8a67e5406be46e971908d69af93bf92b6ff980 Cr-Commit-Position: refs/heads/master@{#41515} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3e8a67e5406be46e971908d69af93bf92b6ff980 Cr-Commit-Position: refs/heads/master@{#41515} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
