Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Unified Diff: content/renderer/input/render_widget_input_handler.cc

Issue 2553923002: Remove deprecated ReplicaInputConnection (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/ime_event_guard.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/input/render_widget_input_handler.cc
diff --git a/content/renderer/input/render_widget_input_handler.cc b/content/renderer/input/render_widget_input_handler.cc
index f9686ca81ecb931de895df0353d0258641cb4b88..cd1e8a42b5578ff084a51ceb57721dc55184531a 100644
--- a/content/renderer/input/render_widget_input_handler.cc
+++ b/content/renderer/input/render_widget_input_handler.cc
@@ -206,33 +206,7 @@ void RenderWidgetInputHandler::HandleInputEvent(
&event_overscroll);
#if defined(OS_ANDROID)
- bool from_ime = false;
-
- // For most keyboard events, we want the change source to be FROM_IME because
- // we don't need to update IME states in ReplicaInputConnection.
- if (!widget_->IsUsingImeThread() &&
- WebInputEvent::isKeyboardEventType(input_event.type)) {
- const WebKeyboardEvent& key_event =
- *static_cast<const WebKeyboardEvent*>(&input_event);
- // TODO(changwan): this if-condition is a stop-gap solution to update IME
- // states in ReplicaInputConnection when using DPAD navigation. This is not
- // a correct solution because InputConnection#getTextBeforeCursor()
- // immediately after InputConnection#sendKeyEvent() will not return the
- // correct value. The correct solution is either redesign the architecture
- // or emulate the DPAD behavior in ReplicaInputConnection, either is
- // non-trivial.
- if (key_event.nativeKeyCode != AKEYCODE_TAB &&
- key_event.nativeKeyCode != AKEYCODE_DPAD_CENTER &&
- key_event.nativeKeyCode != AKEYCODE_DPAD_LEFT &&
- key_event.nativeKeyCode != AKEYCODE_DPAD_RIGHT &&
- key_event.nativeKeyCode != AKEYCODE_DPAD_UP &&
- key_event.nativeKeyCode != AKEYCODE_DPAD_DOWN) {
- from_ime = true;
- }
- }
-
ImeEventGuard guard(widget_);
- guard.set_from_ime(from_ime);
#endif
base::TimeTicks start_time;
« no previous file with comments | « content/renderer/ime_event_guard.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698