Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2553923002: Remove deprecated ReplicaInputConnection (Closed)

Created:
4 years ago by Changwan Ryu
Modified:
4 years ago
CC:
agrieve+watch_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, dtapuska+chromiumwatch_chromium.org, jam, jbudorick+watch_chromium.org, kinuko+watch, mikecase+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, yabinh, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated ReplicaInputConnection Since ImeThread and its ThreadedInputConnection implementation are rolled out to stable, there is no need to keep ReplicaInputConnection and related logics in renderer. Note that this just removes dead code and is purely mechanical. Polish up around ChangeSource will be handled in a separate CL. BUG=662279 Committed: https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05 Cr-Commit-Position: refs/heads/master@{#437422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1059 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/input_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 2 chunks +1 line, -14 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/InputMethodUma.java View 1 chunk +0 lines, -5 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java View 1 chunk +0 lines, -529 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java View 1 chunk +0 lines, -2 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/input/ReplicaInputConnectionTest.java View 1 chunk +0 lines, -180 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/ime_event_guard.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M content/renderer/render_widget.h View 4 chunks +0 lines, -29 lines 0 comments Download
M content/renderer/render_widget.cc View 12 chunks +9 lines, -74 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 2 chunks +0 lines, -115 lines 0 comments Download
M third_party/WebKit/public/web/WebWidgetClient.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 35 (19 generated)
Changwan Ryu
PTAL
4 years ago (2016-12-06 00:22:14 UTC) #3
aelias_OOO_until_Jul13
lgtm, thanks!
4 years ago (2016-12-06 01:54:06 UTC) #9
Changwan Ryu
Adding more reviewers: nasko@chromium.org: Please review changes in content/public/common/content_features.cc and content/common/input_messages.h holte@chromium.org: Please review changes ...
4 years ago (2016-12-06 02:05:08 UTC) #11
jbudorick
On 2016/12/06 02:05:08, Changwan Ryu wrote: > Adding more reviewers: > > mailto:nasko@chromium.org: Please review ...
4 years ago (2016-12-06 02:58:22 UTC) #12
tkent
third_party/WebKit/ lgtm
4 years ago (2016-12-06 06:16:11 UTC) #15
Steven Holte
testing/variations lgtm
4 years ago (2016-12-06 19:54:00 UTC) #16
Changwan Ryu
-nasko@ as he is OOO. dcheng@, could you review input_messages.h? clamy@, could you review content_features.cc? ...
4 years ago (2016-12-07 07:15:58 UTC) #20
dcheng
ipc lgtm
4 years ago (2016-12-07 07:22:27 UTC) #21
clamy
content/public lgtm. Thanks for removing dead code!
4 years ago (2016-12-08 13:27:39 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553923002/1
4 years ago (2016-12-08 16:37:50 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82429)
4 years ago (2016-12-08 18:14:33 UTC) #26
jbudorick
On 2016/12/08 18:14:33, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years ago (2016-12-08 18:15:19 UTC) #27
Changwan Ryu
On 2016/12/08 18:15:19, jbudorick wrote: > On 2016/12/08 18:14:33, commit-bot: I haz the power wrote: ...
4 years ago (2016-12-09 00:57:53 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553923002/1
4 years ago (2016-12-09 00:57:56 UTC) #30
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 01:46:28 UTC) #33
commit-bot: I haz the power
4 years ago (2016-12-09 01:48:29 UTC) #35
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05
Cr-Commit-Position: refs/heads/master@{#437422}

Powered by Google App Engine
This is Rietveld 408576698