Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 2553903002: Changes error code to NotFoundError. (Closed)

Created:
4 years ago by CJ
Modified:
4 years ago
Reviewers:
Stephen, mark a. foltz
CC:
chromium-reviews, feature-media-reviews_chromium.org, media-router+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes error code to NotFoundError. Addresses the second part of Bug 670848, changes the error code to a NoPresentationFound ErrorCode. BUG=670848 Committed: https://crrev.com/f49e92ef385bdb28898d838bb814f8e278259f49 Cr-Commit-Position: refs/heads/master@{#437167}

Patch Set 1 #

Patch Set 2 : Merge branch 'real_master' into Presentation #

Patch Set 3 : Typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
CJ
Please let me know if I missed part of the intended point of the second ...
4 years ago (2016-12-05 23:43:35 UTC) #3
mark a. foltz
lgtm
4 years ago (2016-12-07 06:31:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553903002/1
4 years ago (2016-12-08 00:07:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/176863) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-08 00:10:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553903002/40001
4 years ago (2016-12-08 02:00:49 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 03:31:10 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-08 03:34:10 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f49e92ef385bdb28898d838bb814f8e278259f49
Cr-Commit-Position: refs/heads/master@{#437167}

Powered by Google App Engine
This is Rietveld 408576698