Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2553803003: Refactor HTMLLinkElement

Created:
4 years ago by tyoshino (SeeGerritForStatus)
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, Yoav Weiss, gavinp+prerender_chromium.org, blink-reviews-style_chromium.org, webcomponents-bugzilla_chromium.org, tfarina, blink-reviews-html_chromium.org, dglazkov+blink, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor HTMLLinkElement - HTMLLinkElement should create LinkLoader only when needed - Remove LinkRequestBuilder and have createFetchRequest() method on HTMLLinkElement instead - Make LinkResource simple: - Provide access to the owner - Interfaces to receive events common to all LinkResources - LinkResourceType getter - Remove shouldLoadResource() from LinkResource - Remove loadingFrame() from LinkResource LinkStyle clean up - Remove LoadReturnValue from LinkStyle. We can just run the block inside the last if-clause in process() in loadStylesheetIfNeeded() where NotNeeded was returned - Remove setFetchFollowingCORS() and clearFetchFollowingCORS(). They don't add much value for readability. We can just change the variable directly - Add a helper to access m_owner->document() for const methods - Use the non-const document() helper method where possible HTMLImportsController - Move HTMLImport retrieval logic to load() method from LinkImport BUG=671531

Patch Set 1 : a #

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -170 lines) Patch
M third_party/WebKit/Source/core/html/HTMLLinkElement.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 3 chunks +17 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkResource.h View 3 chunks +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkResource.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.h View 1 3 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.cpp View 1 11 chunks +109 lines, -84 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportsController.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp View 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/LinkImport.cpp View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (6 generated)
tyoshino (SeeGerritForStatus)
Description was changed from ========== Refactor HTMLLinkElement BUG=none ========== to ========== Refactor HTMLLinkElement - HTMLLinkElement ...
4 years ago (2016-12-06 08:32:47 UTC) #1
tyoshino (SeeGerritForStatus)
Patchset #1 (id:1) has been deleted
4 years ago (2016-12-06 08:34:01 UTC) #2
tyoshino (SeeGerritForStatus)
Patchset #1 (id:20001) has been deleted
4 years ago (2016-12-06 08:34:08 UTC) #3
tyoshino (SeeGerritForStatus)
Description was changed from ========== Refactor HTMLLinkElement - HTMLLinkElement should create LinkLoader only when needed ...
4 years ago (2016-12-06 08:40:11 UTC) #4
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run
4 years ago (2016-12-06 08:40:31 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-06 08:40:42 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698