Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3220)

Unified Diff: content/renderer/render_frame_proxy.cc

Issue 2553783003: Don't consume user gesture in RenderFrameProxy::navigate. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_site_per_process_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_proxy.cc
diff --git a/content/renderer/render_frame_proxy.cc b/content/renderer/render_frame_proxy.cc
index 8f429c68c4b94f2e76c960d3842550098535b48f..58adfeaa1590d963311f6742f93005356bc9e77a 100644
--- a/content/renderer/render_frame_proxy.cc
+++ b/content/renderer/render_frame_proxy.cc
@@ -460,9 +460,7 @@ void RenderFrameProxy::navigate(const blink::WebURLRequest& request,
request.referrerPolicy());
params.disposition = WindowOpenDisposition::CURRENT_TAB;
params.should_replace_current_entry = should_replace_current_entry;
- params.user_gesture =
- blink::WebUserGestureIndicator::isProcessingUserGesture();
- blink::WebUserGestureIndicator::consumeUserGesture();
+ params.user_gesture = request.hasUserGesture();
alexmos 2016/12/06 01:58:05 We already set this on the request in RemoteFrame:
Send(new FrameHostMsg_OpenURL(routing_id_, params));
}
« no previous file with comments | « chrome/browser/chrome_site_per_process_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698