Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Issue 2553773002: Run the WebGL conformance tests with the passthrough command decoder. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/gpu/generate_buildbot_json.py ('k') | testing/buildbot/chromium.gpu.fyi.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
index 82d788394e9a8cdeb9ad3a310e3ea8b937e08d9d..eea4e8cb1c7f91d04d225de5b66a120edf2738b7 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
@@ -171,9 +171,9 @@ bool GLES2DecoderPassthroughImpl::Initialize(
// Check for required extensions
if (!feature_info_->feature_flags().angle_robust_client_memory ||
- !feature_info_->feature_flags().chromium_bind_generates_resource ||
- (feature_info_->IsWebGLContext() !=
- feature_info_->feature_flags().angle_webgl_compatibility)) {
+ !feature_info_->feature_flags().chromium_bind_generates_resource) {
+ // TODO(geofflang): Verify that ANGLE_webgl_compatibility is enabled if this
+ // is a WebGL context (depends on crbug.com/671217).
Destroy(true);
return false;
}
« no previous file with comments | « content/test/gpu/generate_buildbot_json.py ('k') | testing/buildbot/chromium.gpu.fyi.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698