content/browser/media/capture/web_contents_video_capture_device.cc - Issue 2553763002: Fix cursor missing in tabCapture on OSX Sierra

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/web_contents_video_capture_device.cc

Issue 2553763002: Fix cursor missing in tabCapture on OSX Sierra (Closed)

Patch Set: address comments and implement mouse tracking on Mac Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/media/capture/web_contents_video_capture_device.cc

diff --git a/content/browser/media/capture/web_contents_video_capture_device.cc b/content/browser/media/capture/web_contents_video_capture_device.cc

index d258238ef7e97762740a5c88a48ce5dbab96c9b2..6951d4279933bdf1338e9d76cf070cf6bc975b46 100644

--- a/content/browser/media/capture/web_contents_video_capture_device.cc

+++ b/content/browser/media/capture/web_contents_video_capture_device.cc

@@ -374,7 +374,7 @@ void FrameSubscriber::DidCaptureFrame(

CursorRenderer* cursor_renderer =

frame_subscriber_->cursor_renderer_.get();

if (cursor_renderer->SnapshotCursorState(region_in_frame))

- cursor_renderer->RenderOnVideoFrame(frame);

+ cursor_renderer->RenderOnVideoFrame(frame.get());

frame->metadata()->SetBoolean(

media::VideoFrameMetadata::INTERACTIVE_CONTENT,

frame_subscriber_->IsUserInteractingWithContent());