content/browser/media/capture/aura_window_capture_machine.cc - Issue 2553763002: Fix cursor missing in tabCapture on OSX Sierra

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/aura_window_capture_machine.cc

Issue 2553763002: Fix cursor missing in tabCapture on OSX Sierra (Closed)

Patch Set: address comments and implement mouse tracking on Mac Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/media/capture/aura_window_capture_machine.cc

diff --git a/content/browser/media/capture/aura_window_capture_machine.cc b/content/browser/media/capture/aura_window_capture_machine.cc

index 561e68a6f509eafb43df0c15ebfe1d3ba649c735..2e7432ac1ed67e2c6bd55f5abd69e57809736ba8 100644

--- a/content/browser/media/capture/aura_window_capture_machine.cc

+++ b/content/browser/media/capture/aura_window_capture_machine.cc

@@ -363,7 +363,7 @@ void AuraWindowCaptureMachine::CopyOutputFinishedForVideo(

// still valid).

if (machine) {

if (machine->cursor_renderer_ && result)

- machine->cursor_renderer_->RenderOnVideoFrame(target);

+ machine->cursor_renderer_->RenderOnVideoFrame(target.get());

} else {

VLOG(1) << "Aborting capture: AuraWindowCaptureMachine has gone away.";

result = false;