Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2553713002: [Merge M-56] arc: Reduce logspam when ARC is not enabled/available (Closed)

Created:
4 years ago by Luis Héctor Chávez
Modified:
4 years ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, cbentzel+watch_chromium.org, yusukes+watch_chromium.org, abhishekbh_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, Sameer Nanda, oshima+watch_chromium.org, Kevin Cernekee, davemoore+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge M-56] arc: Reduce logspam when ARC is not enabled/available There are some Chrome services that unconditionally try to call ARC code, and the latter will print stuff to the log if it's not enabled or avilable (yet). This change ensures that we only attempt to contact ARC when it is actually ready for the most chatty services: net and process. BUG=654038 TEST=Opted out of ARC, did not see any logs TBR=yusukes@chromium.org Review-Url: https://codereview.chromium.org/2541843003 Cr-Commit-Position: refs/heads/master@{#435534} (cherry picked from commit edea73c00927636fe885af9205c668633e65a691) Committed: https://chromium.googlesource.com/chromium/src/+/26ed24fd38f8c2b64ced3d3bb61ac04686d698ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -12 lines) Patch
M chrome/browser/chromeos/arc/process/arc_process_service.h View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/process/arc_process_service.cc View 3 chunks +20 lines, -7 lines 0 comments Download
M components/arc/net/arc_net_host_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M components/arc/net/arc_net_host_impl.cc View 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Luis Héctor Chávez
4 years ago (2016-12-05 17:26:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26ed24fd38f8c2b64ced3d3bb61ac04686d698ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698