Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2553703003: Made border-collapse property independent. (Closed)

Created:
4 years ago by napper
Modified:
4 years ago
Reviewers:
nainar, sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made border-collapse property independent. Made border-collapse property independent. Also updated independent-inheritance-fast-path.html to include borderCollapse. Tested using independent-inheritance-fast-path.html. BUG=628043 Committed: https://crrev.com/472c0e40aeb583e2638eb45c79f7ae931d10bceb Cr-Commit-Position: refs/heads/master@{#436867}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Added TODO to remove compareEqualIndependent() when all independent properties are generated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 25 (15 generated)
napper
4 years ago (2016-12-07 02:00:45 UTC) #11
sashab
So cooool!! :D Send this to nainar@ for review before me But before you do.. ...
4 years ago (2016-12-07 02:03:36 UTC) #12
napper
Added TODO() but there are still non-generated independent properties, so I have not updated the ...
4 years ago (2016-12-07 02:21:17 UTC) #13
napper
4 years ago (2016-12-07 02:22:23 UTC) #15
napper
4 years ago (2016-12-07 02:22:25 UTC) #16
nainar
lgtm
4 years ago (2016-12-07 02:30:31 UTC) #17
sashab
lgtm! \o/ exciting times
4 years ago (2016-12-07 02:31:01 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553703003/40001
4 years ago (2016-12-07 02:32:45 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-07 05:03:05 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-07 05:07:23 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/472c0e40aeb583e2638eb45c79f7ae931d10bceb
Cr-Commit-Position: refs/heads/master@{#436867}

Powered by Google App Engine
This is Rietveld 408576698