Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2553673003: [Merge to M55] Reland "Propagate information about how ARC apps are launched" (Closed)

Created:
4 years ago by Luis Héctor Chávez
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, elijahtaylor+arcwatch_chromium.org, michaelpg+watch-options_chromium.org, sadrul, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, arv+watch_chromium.org, kalyank, Matt Giuca
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Merge to M55] Reland "Propagate information about how ARC apps are launched" This change lets ARC know whether an app should be launched in Touch Mode[1] or not. 1: http://android-developers.blogspot.com/2008/12/touch-mode.html BUG=669146 TEST=ARC app starts in touch mode when activated using mouse/trackpad/touch TEST=ARC app starts in focus mode when activated using keyboard. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=stevenjb@chromium.org Committed: https://crrev.com/b5898c35b2415dbf8b5d9aaa19a6b13b0510d1e7 Review-Url: https://codereview.chromium.org/2540433002 Cr-Original-Commit-Position: refs/heads/master@{#435115} Cr-Commit-Position: refs/heads/master@{#435327} (cherry picked from commit fa0327a360d5e676680a4b5337a607958c0512d0) Committed: https://chromium.googlesource.com/chromium/src/+/040236864a5d7781562b747479c600fce02b99b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -56 lines) Patch
M chrome/browser/resources/options/browser_options.js View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.h View 2 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 14 chunks +79 lines, -26 lines 0 comments Download
M chrome/browser/ui/app_list/search/arc_app_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.h View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_controller_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Luis Héctor Chávez
4 years ago (2016-12-05 20:51:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
040236864a5d7781562b747479c600fce02b99b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698