Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2553673002: Disallow off-heap containers containing raw on-heap pointers. (Closed)

Created:
4 years ago by sof
Modified:
4 years ago
CC:
chromium-reviews, krit, rwlbuis, fs, f(malita), Mikhail, blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, blink-reviews-wtf_chromium.org, pdr+svgwatchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow off-heap containers containing raw on-heap pointers. R= BUG= Committed: https://crrev.com/cc7c5ec24b2b41da393f6502318394a015186625 Cr-Commit-Position: refs/heads/master@{#436351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -20 lines) Patch
M third_party/WebKit/Source/core/frame/csp/SourceListDirective.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp View 3 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashCountedSet.h View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashMap.h View 1 chunk +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashSet.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSet.h View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sof
please take a look. Vector<> & Deque<> already checks for this off-heap case.
4 years ago (2016-12-05 15:15:31 UTC) #5
haraken
LGTM
4 years ago (2016-12-05 15:23:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553673002/1
4 years ago (2016-12-05 18:09:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 18:16:00 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-05 18:19:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc7c5ec24b2b41da393f6502318394a015186625
Cr-Commit-Position: refs/heads/master@{#436351}

Powered by Google App Engine
This is Rietveld 408576698