Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2553643002: Remove FLAG_flush_optimized_code_cache (Closed)

Created:
4 years ago by mvstanton
Modified:
4 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove FLAG_flush_optimized_code_cache It's no longer necessary, and has been off for a year. BUG= Committed: https://crrev.com/3e46a3b75437fbb6193eca915c914fcf1fff797f Cr-Commit-Position: refs/heads/master@{#41499}

Patch Set 1 #

Patch Set 2 : test fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M src/heap/objects-visiting-inl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-513507.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
mvstanton
Hi Michael, Here is the CL we discussed, thanks! --Mike
4 years ago (2016-12-05 14:03:43 UTC) #4
Michael Starzinger
LGTM. Could you also adapt the mjsunit/regress/regress-crbug-513507.js test case?
4 years ago (2016-12-05 17:00:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553643002/20001
4 years ago (2016-12-05 17:56:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 18:28:19 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-05 18:28:35 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e46a3b75437fbb6193eca915c914fcf1fff797f
Cr-Commit-Position: refs/heads/master@{#41499}

Powered by Google App Engine
This is Rietveld 408576698