Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2553603002: New accessibility virtual keyboard behavior in non-sticky mode. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 76a1748db19a81d074fc11cfde8afa814f459e66..80ba547bfb25f1aa33d38db6c77ba74af1f0c106 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -83,6 +83,7 @@
#include "ui/aura/window_event_dispatcher.h"
#include "ui/aura/window_observer.h"
#include "ui/base/clipboard/clipboard.h"
+#include "ui/base/ui_base_switches.h"
#include "ui/base/ui_base_types.h"
#include "ui/compositor/compositor.h"
#include "ui/compositor/layer_tree_owner.h"
@@ -102,6 +103,10 @@
#include "ui/wm/core/default_screen_position_client.h"
#include "ui/wm/core/window_util.h"
+#if defined(OS_CHROMEOS)
+#include "ui/base/ime/input_method.h"
+#endif
+
using testing::_;
using blink::WebGestureEvent;
@@ -4687,6 +4692,56 @@ TEST_F(RenderWidgetHostViewAuraOverscrollTest, OverscrollResetsOnBlur) {
EXPECT_EQ(4U, sink_->message_count());
}
+#if defined(OS_CHROMEOS)
+// Check that when accessibility virtual keyboard is enabled, windows are
+// shifted up when focused and restored when focus is lost.
+TEST_F(RenderWidgetHostViewAuraTest, VirtualKeyboardFocusEnsureCaretInRect) {
+ // TODO (oshima): Test that overscroll occurs.
+
+ // Enable new virtual keyboard behavior.
+ base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+ if (!command_line->HasSwitch(::switches::kUseNewVirtualKeyboardBehavior))
+ command_line->AppendSwitch(::switches::kUseNewVirtualKeyboardBehavior);
+
+ view_->InitAsChild(nullptr);
+ aura::client::ParentWindowWithContext(
+ view_->GetNativeView(), parent_view_->GetNativeView()->GetRootWindow(),
+ gfx::Rect());
+ aura::Window* root_window = parent_view_->GetNativeView()->GetRootWindow();
+ wm::DefaultScreenPositionClient screen_position_client;
+ aura::client::SetScreenPositionClient(root_window, &screen_position_client);
+
+ const gfx::Rect orig_view_bounds = gfx::Rect(0, 300, 400, 200);
+ const gfx::Rect shifted_view_bounds = gfx::Rect(0, 200, 400, 200);
+ const gfx::Rect root_bounds = root_window->bounds();
+ const int keyboard_height = 200;
+ const gfx::Rect keyboard_view_bounds =
+ gfx::Rect(0, root_bounds.height() - keyboard_height, root_bounds.width(),
+ keyboard_height);
+
+ ui::InputMethod* input_method = root_window->GetHost()->GetInputMethod();
+
+ // Focus the window.
+ view_->SetBounds(orig_view_bounds);
+ input_method->SetFocusedTextInputClient(view_);
+ EXPECT_EQ(view_->GetNativeView()->bounds(), orig_view_bounds);
+
+ // Simulate virtual keyboard.
+ input_method->SetOnScreenKeyboardBounds(keyboard_view_bounds);
+
+ // Window should be shifted.
+ EXPECT_EQ(view_->GetNativeView()->bounds(), shifted_view_bounds);
+
+ // Detach the RenderWidgetHostViewAura from the IME.
+ view_->DetachFromInputMethod();
+
+ // Window should be restored.
+ EXPECT_EQ(view_->GetNativeView()->bounds(), orig_view_bounds);
+
+ aura::client::SetScreenPositionClient(root_window, nullptr);
+}
+#endif // defined(OS_CHROMEOS)
+
// Tests that when view initiated shutdown happens (i.e. RWHView is deleted
// before RWH), we clean up properly and don't leak the RWHVGuest.
TEST_F(RenderWidgetHostViewGuestAuraTest, GuestViewDoesNotLeak) {
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698