Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: model.py

Issue 25536018: Support revisions with str type for try jobs. Base URL: https://src.chromium.org/chrome/trunk/tools/commit-queue/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pending_manager.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: model.py
===================================================================
--- model.py (revision 226737)
+++ model.py (working copy)
@@ -240,9 +240,6 @@
continue
if not all(i is None or i.__class__ == type for i in item_value):
continue
- if any(i is str for i in item_value):
- raise TypeError(
- '%s is type \'str\' which is currently not supported' % item)
item_value = tuple(
f if f is not None else None.__class__ for f in item_value)
persistent_members_cache[item] = item_value
« no previous file with comments | « no previous file | pending_manager.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698