model.py - Issue 25536018: Support revisions with str type for try jobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: model.py

Issue 25536018: Support revisions with str type for try jobs. Base URL: https://src.chromium.org/chrome/trunk/tools/commit-queue/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: model.py

===================================================================

--- model.py (revision 226737)

+++ model.py (working copy)

@@ -240,9 +240,6 @@

continue

if not all(i is None or i.__class__ == type for i in item_value):

continue

- if any(i is str for i in item_value):

- raise TypeError(

- '%s is type \'str\' which is currently not supported' % item)

item_value = tuple(

f if f is not None else None.__class__ for f in item_value)

persistent_members_cache[item] = item_value

« no previous file with comments | « no previous file | pending_manager.py » ('j') | no next file with comments »