Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 25536007: Remove spawnDomIsolate code (Closed)

Created:
7 years, 2 months ago by vsm
Modified:
7 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove spawnDomIsolate code This is more or less a straight remove of code. By disabling print and timers on background isolates in Dartium, we can get rid of the last vestiges of spawnDom*. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28191

Patch Set 1 #

Patch Set 2 : fix spacing #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -110 lines) Patch
M tests/html/html.status View 1 chunk +1 line, -0 lines 1 comment Download
M tests/isolate/isolate.status View 1 chunk +2 lines, -0 lines 1 comment Download
M tools/dom/src/native_DOMImplementation.dart View 1 3 chunks +4 lines, -110 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
https://codereview.chromium.org/25536007/diff/2001/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/25536007/diff/2001/tests/html/html.status#newcode34 tests/html/html.status:34: async_test: Fail # Background timers not implemented. If this ...
7 years, 2 months ago (2013-10-01 21:02:31 UTC) #1
siva
lgtm
7 years, 2 months ago (2013-10-03 00:21:16 UTC) #2
vsm
7 years, 2 months ago (2013-10-03 03:20:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r28191 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698