Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: content/browser/loader/resource_handler.h

Issue 25536005: Clean up ResourceHandler API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_handler.h
diff --git a/content/browser/loader/resource_handler.h b/content/browser/loader/resource_handler.h
index de8bd9dc1cf340b46769f8281501830a538899f0..8ec4117e80c7d939c15fa414dd44ec3009049581 100644
--- a/content/browser/loader/resource_handler.h
+++ b/content/browser/loader/resource_handler.h
@@ -14,6 +14,7 @@
#include <string>
+#include "base/memory/ref_counted.h"
#include "base/sequenced_task_runner_helpers.h"
#include "base/threading/non_thread_safe.h"
#include "content/common/content_export.h"
@@ -22,11 +23,14 @@ class GURL;
namespace net {
class IOBuffer;
+class URLRequest;
class URLRequestStatus;
} // namespace net
namespace content {
class ResourceController;
+class ResourceMessageFilter;
+class ResourceRequestInfoImpl;
struct ResourceResponse;
// The resource dispatcher host uses this interface to process network events
@@ -77,7 +81,7 @@ class CONTENT_EXPORT ResourceHandler
// If the handler returns false, then the request is cancelled. Otherwise,
// once data is available, OnReadCompleted will be called.
virtual bool OnWillRead(int request_id,
- net::IOBuffer** buf,
+ scoped_refptr<net::IOBuffer>* buf,
int* buf_size,
int min_size) = 0;
@@ -102,11 +106,19 @@ class CONTENT_EXPORT ResourceHandler
virtual void OnDataDownloaded(int request_id, int bytes_downloaded) = 0;
protected:
- ResourceHandler() : controller_(NULL) {}
- ResourceController* controller() { return controller_; }
+ ResourceHandler(net::URLRequest* request);
+
+ ResourceController* controller() const { return controller_; }
+ net::URLRequest* request() const { return request_; }
+
+ // Convenience functions.
+ ResourceRequestInfoImpl* GetRequestInfo() const;
+ int GetRequestID() const;
+ ResourceMessageFilter* GetFilter() const;
private:
ResourceController* controller_;
+ net::URLRequest* request_;
};
} // namespace content
« no previous file with comments | « content/browser/loader/redirect_to_file_resource_handler.cc ('k') | content/browser/loader/resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698