Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2553563004: [ios] Adds JS resources for various features. (Closed)

Created:
4 years ago by rohitrao (ping after 24h)
Modified:
4 years ago
Reviewers:
sczs, sdefresne, sczs1
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds JS resources for various features. BUG=662936 Committed: https://crrev.com/1bd1f12d6c2dec504123251c637e11496764a9da Cr-Commit-Position: refs/heads/master@{#436500}

Patch Set 1 : Upload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2142 lines, -0 lines) Patch
A ios/chrome/browser/payments/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
A ios/chrome/browser/payments/resources/payment_request_manager.js View 1 chunk +402 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/BUILD.gn View 2 chunks +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/contextual_search/resources/contextualsearch.js View 1 chunk +1341 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/contextual_search/resources/contextualsearch_unittest.js View 1 chunk +42 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/downloads/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/downloads/resources/DownloadManagerController.xib View 1 chunk +204 lines, -0 lines 0 comments Download
M ios/chrome/browser/web/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/resources/PRESUBMIT.py View 1 chunk +87 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/resources/print.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
rohitrao (ping after 24h)
4 years ago (2016-12-05 22:03:25 UTC) #3
sczs1
lgtm *Those were all the non-images resources files I found too.
4 years ago (2016-12-05 22:07:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553563004/20001
4 years ago (2016-12-05 23:50:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/79877)
4 years ago (2016-12-06 01:32:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553563004/20001
4 years ago (2016-12-06 01:53:22 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-06 02:50:28 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-06 02:54:01 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bd1f12d6c2dec504123251c637e11496764a9da
Cr-Commit-Position: refs/heads/master@{#436500}

Powered by Google App Engine
This is Rietveld 408576698