Link Swarming Tasklist and Botlist together

Link Swarming Tasklist and Botlist together

The "View matching" link will preserve dimensions between pages, allowing
easy traversal and comparison.

Additionally, there are some minor changes:
- Add more GPU aliases
- Don't show bot_cache stats if they aren't there
- Fix bug where something like "gpu:8086:9874" wasn't considered a valid
  filter.
- Bot-page now has a linkable dimensions (like task-page), which allows 
  finding bots with identical dimensions.

BUG=

Committed: https://github.com/luci/luci-py/commit/0b80f3f3a1f449087b29d33d81014c2e5c4a452d

[kjlubick, 2016-12-05 18:06:30]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-12-05 18:06:31]

See it live at
https://2514-d64460c-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/botl...

https://screenshot.googleplex.com/SEcQCVLdrFA
https://screenshot.googleplex.com/293qVN2rFa4

[kjlubick, 2016-12-05 18:45:46]

Description was changed from

==========
Link Swarming Tasklist and Botlist together

The "View matching" link will preserve dimensions between pages, allowing
easy traversal and comparision.

Additionally, there are some minor chanes:
- Add more GPU aliases
- Don't show bot_cache stats if they aren't there
- Fix bug where something like "gpu:8086:9874" wasn't considered a valid
  filter.

BUG=
==========

to

==========
Link Swarming Tasklist and Botlist together

The "View matching" link will preserve dimensions between pages, allowing
easy traversal and comparison.

Additionally, there are some minor changes:
- Add more GPU aliases
- Don't show bot_cache stats if they aren't there
- Fix bug where something like "gpu:8086:9874" wasn't considered a valid
  filter.
- Bot-page now has a linkable dimensions (like task-page), which allows 
  finding bots with identical dimensions.

BUG=
==========

[stephana, 2016-12-06 18:43:39]

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/botlist/bot-filters.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botlist/bot-filters.html:308: var cols = ["name",
"state", "created_ts"];
Are these constants local to this function not used anywhere else ? 
Otherwise they should be constants somewhere. Same in bot-page.html.

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/common/common-behavior.html:35: // of Strings,
where the Strings are valid filters (e.g. "foo:bar") and
typo: "array of Strings of Strings"

[kjlubick, 2016-12-06 18:50:32]

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/botlist/bot-filters.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botlist/bot-filters.html:308: var cols = ["name",
"state", "created_ts"];
On 2016/12/06 at 18:43:39, stephana wrote:
> Are these constants local to this function not used anywhere else ? 
> Otherwise they should be constants somewhere. Same in bot-page.html.

These are just the default columns I want to display.  They aren't used anywhere
else.

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/common/common-behavior.html:35: // of Strings,
where the Strings are valid filters (e.g. "foo:bar") and
On 2016/12/06 at 18:43:39, stephana wrote:
> typo: "array of Strings of Strings"

Done.

[jcgregorio, 2016-12-06 18:51:55]

lgtm

Just some nits.

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/botlist/bot-filters.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botlist/bot-filters.html:307: _matchingTasksLink:
function(queryParams) {
Use query_params to be consistent.

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/botpage/bot-page.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botpage/bot-page.html:199: <a
href$="[[_siblingBotsLink(_bot.dimensions)]]" title="The list of bots that also
matches these dimensions (except id)"> Dimensions</a>
nit. Complete sentences.

... (except id)."

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botpage/bot-page.html:602: dimensions =
dimensions.filter(function(f){
Could drop this if the forEach below was:

          if f.key !== "id" && (cols.indexOf(f.key) === -1) {
            cols.push(f.key);
          }

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botpage/bot-page.html:606:
console.log(dimensions);
stray log

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/common/common-behavior.html:33: // filters should
be an array of {key:String, value:String} or an array
Document arg params like you did in task-list-data.html.

Here and for _taskListLink.

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/tasklist/task-filters.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/tasklist/task-filters.html:269: var col =
t.split(this.FILTER_SEP, 1)[0];
Same as above, could be folded into forEach below.

[stephana, 2016-12-06 20:04:43]

On 2016/12/06 18:51:55, jcgregorio wrote:
> lgtm
> 
> Just some nits.
> 
>
https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
> File appengine/swarming/ui/res/imp/botlist/bot-filters.html (right):
> 
>
https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
> appengine/swarming/ui/res/imp/botlist/bot-filters.html:307:
_matchingTasksLink:
> function(queryParams) {
> Use query_params to be consistent.
> 
>
https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
> File appengine/swarming/ui/res/imp/botpage/bot-page.html (right):
> 
>
https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
> appengine/swarming/ui/res/imp/botpage/bot-page.html:199: <a
> href$="[[_siblingBotsLink(_bot.dimensions)]]" title="The list of bots that
also
> matches these dimensions (except id)"> Dimensions</a>
> nit. Complete sentences.
> 
> ... (except id)."
> 
>
https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
> appengine/swarming/ui/res/imp/botpage/bot-page.html:602: dimensions =
> dimensions.filter(function(f){
> Could drop this if the forEach below was:
> 
>           if f.key !== "id" && (cols.indexOf(f.key) === -1) {
>             cols.push(f.key);
>           }
> 
>
https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
> appengine/swarming/ui/res/imp/botpage/bot-page.html:606:
> console.log(dimensions);
> stray log
> 
>
https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
> File appengine/swarming/ui/res/imp/common/common-behavior.html (right):
> 
>
https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
> appengine/swarming/ui/res/imp/common/common-behavior.html:33: // filters
should
> be an array of {key:String, value:String} or an array
> Document arg params like you did in task-list-data.html.
> 
> Here and for _taskListLink.
> 
>
https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
> File appengine/swarming/ui/res/imp/tasklist/task-filters.html (right):
> 
>
https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
> appengine/swarming/ui/res/imp/tasklist/task-filters.html:269: var col =
> t.split(this.FILTER_SEP, 1)[0];
> Same as above, could be folded into forEach below.

lgtm

[kjlubick, 2016-12-06 20:05:28]

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/botlist/bot-filters.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botlist/bot-filters.html:307: _matchingTasksLink:
function(queryParams) {
On 2016/12/06 at 18:51:54, jcgregorio wrote:
> Use query_params to be consistent.

Done.

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/botpage/bot-page.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botpage/bot-page.html:199: <a
href$="[[_siblingBotsLink(_bot.dimensions)]]" title="The list of bots that also
matches these dimensions (except id)"> Dimensions</a>
On 2016/12/06 at 18:51:54, jcgregorio wrote:
> nit. Complete sentences.
> 
> ... (except id)."

Done.

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botpage/bot-page.html:602: dimensions =
dimensions.filter(function(f){
On 2016/12/06 at 18:51:55, jcgregorio wrote:
> Could drop this if the forEach below was:
> 
>           if f.key !== "id" && (cols.indexOf(f.key) === -1) {
>             cols.push(f.key);
>           }

I also need to remove the dimension where key == "id" from dimensions, so I
think I do need this filter.

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botpage/bot-page.html:606:
console.log(dimensions);
On 2016/12/06 at 18:51:54, jcgregorio wrote:
> stray log

Removed.

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/common/common-behavior.html:33: // filters should
be an array of {key:String, value:String} or an array
On 2016/12/06 at 18:51:55, jcgregorio wrote:
> Document arg params like you did in task-list-data.html.
> 
> Here and for _taskListLink.

Done.

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/tasklist/task-filters.html (right):

https://codereview.chromium.org/2553563003/diff/40001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/tasklist/task-filters.html:269: var col =
t.split(this.FILTER_SEP, 1)[0];
On 2016/12/06 at 18:51:55, jcgregorio wrote:
> Same as above, could be folded into forEach below.

I still need to filter dimensions, for the same reasons as above.

[KevinL, 2016-12-06 20:08:53]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-12-06 20:08:53]

The CQ bit was checked by kjlubick@chromium.org

[KevinL, 2016-12-06 20:08:54]

lgtm

[KevinL, 2016-12-06 20:08:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com, stephana@google.com
Link to the patchset: https://codereview.chromium.org/2553563003/#ps100001
(title: "Rebuild")

[commit-bot: I haz the power, 2016-12-06 20:09:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 20:13:00]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481054933491150,
"parent_rev": "7accffd689653e501f311a82d5dd15c61b3cd123", "commit_rev":
"0b80f3f3a1f449087b29d33d81014c2e5c4a452d"}

[commit-bot: I haz the power, 2016-12-06 20:13:04]

Description was changed from

==========
Link Swarming Tasklist and Botlist together

The "View matching" link will preserve dimensions between pages, allowing
easy traversal and comparison.

Additionally, there are some minor changes:
- Add more GPU aliases
- Don't show bot_cache stats if they aren't there
- Fix bug where something like "gpu:8086:9874" wasn't considered a valid
  filter.
- Bot-page now has a linkable dimensions (like task-page), which allows 
  finding bots with identical dimensions.

BUG=
==========

to

==========
Link Swarming Tasklist and Botlist together

The "View matching" link will preserve dimensions between pages, allowing
easy traversal and comparison.

Additionally, there are some minor changes:
- Add more GPU aliases
- Don't show bot_cache stats if they aren't there
- Fix bug where something like "gpu:8086:9874" wasn't considered a valid
  filter.
- Bot-page now has a linkable dimensions (like task-page), which allows 
  finding bots with identical dimensions.

BUG=

Committed:
https://github.com/luci/luci-py/commit/0b80f3f3a1f449087b29d33d81014c2e5c4a452d
==========

[commit-bot: I haz the power, 2016-12-06 20:13:05]

Committed patchset #6 (id:100001) as
https://github.com/luci/luci-py/commit/0b80f3f3a1f449087b29d33d81014c2e5c4a452d