Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2553553002: memory coordinator: Throttle foreground renderers on SUSPENDED state (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

memory coordinator: Throttle foreground renderers on SUSPENDED state Like the browser process, we don't want to suspend foreground renderers, but memory coordinator should try to reduce memory consumption when free memory is low. Set THROTTLED state for foreground renderers when the global state is SUSPENDED. BUG=617492 Committed: https://crrev.com/2d5bc88c8a8900eee1513a707ac360b64070e7d7 Cr-Commit-Position: refs/heads/master@{#436481}

Patch Set 1 #

Patch Set 2 : Fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -37 lines) Patch
M content/browser/memory/memory_coordinator.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/memory/memory_coordinator.cc View 3 chunks +6 lines, -16 lines 0 comments Download
M content/browser/memory/memory_coordinator_browsertest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/memory/memory_coordinator_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
bashi
PTAL? As discussed, I want to throttle foreground renderers when the global state is SUSPENDED.
4 years ago (2016-12-06 01:05:53 UTC) #10
haraken
LGTM
4 years ago (2016-12-06 01:08:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553553002/20001
4 years ago (2016-12-06 01:13:42 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 01:19:13 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-06 01:23:46 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d5bc88c8a8900eee1513a707ac360b64070e7d7
Cr-Commit-Position: refs/heads/master@{#436481}

Powered by Google App Engine
This is Rietveld 408576698