Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: third_party/WebKit/Tools/Scripts/test-webkitpy

Issue 2553503002: NOT FOR LANDING: How do we add unit tests for bindings? (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/test-webkitpy
diff --git a/third_party/WebKit/Tools/Scripts/test-webkitpy b/third_party/WebKit/Tools/Scripts/test-webkitpy
index 4e2c7bd7633166853b7468b7677a11afb087c1ac..47bcab1cf1dd691200c860532ac435875c00a09d 100755
--- a/third_party/WebKit/Tools/Scripts/test-webkitpy
+++ b/third_party/WebKit/Tools/Scripts/test-webkitpy
@@ -31,6 +31,8 @@
import os
import sys
+from webkitpy.bindings import bindings_path_finder
+
dirname = os.path.dirname
scripts_dir = dirname(os.path.realpath(__file__))
chromium_src_dir = dirname(dirname(dirname(dirname(scripts_dir))))
@@ -54,7 +56,13 @@ if sys.platform == 'win32':
'webkitpy.layout_tests.layout_package.bot_test_expectations_unittest.*',
]
-sys.exit(typ.main(top_level_dir=scripts_dir,
- skip=skip,
- path=[os.path.join(scripts_dir, 'webkitpy', 'thirdparty')],
- win_multiprocessing='spawn'))
+ret = typ.main(top_level_dir=scripts_dir,
+ skip=skip,
+ path=[os.path.join(scripts_dir, 'webkitpy', 'thirdparty')],
+ win_multiprocessing='spawn')
+if ret == 0:
+ ret = typ.main(top_level_dir=bindings_path_finder.get_bindings_scripts(),
+ skip=[],
+ path=[os.path.join(scripts_dir, 'webkitpy', 'thirdparty')],
+ win_multiprocessing='spawn')
+sys.exit(ret)

Powered by Google App Engine
This is Rietveld 408576698