Fix rebuilding the profile selector on the OSX App Launcher.

Fix rebuilding the profile selector on the OSX App Launcher.

rebuildMenu was only rebuilding the NSMenu, not the menu Model. Do both.

Also add tests, and remove the unused AppListMenu::CURRENT_USER, to fix
a broken test related to the test not observing the user model properly.

BUG=302882
TEST=Open the App Launcher on OSX. Go to chrome://settings and add a
user. The new user should appear in the App Lanucher profile selctor.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226435

[tapted, 2013-10-02 03:56:33]

https://codereview.chromium.org/25535006/diff/1/ui/app_list/cocoa/apps_search...
File ui/app_list/cocoa/apps_search_box_controller_unittest.mm (right):

https://codereview.chromium.org/25535006/diff/1/ui/app_list/cocoa/apps_search...
ui/app_list/cocoa/apps_search_box_controller_unittest.mm:184:
EXPECT_EQ(AppListMenu::SELECT_PROFILE, menu_model->GetItemCount());
This line actually had a bug. Adding the AppListModelObserver exposed it.

The problem is that there is no item for 'CURRENT_USER' -- SELECT_PROFILE had a
value of 4, but there are only 3 items: Settings, Help, Send Feedback.

Removing the unused CURRENT_USER enum value gives SELECT_PROFILE a value of 3,
and this test passes again.

[calamity, 2013-10-02 05:11:27]

lgtm

[commit-bot: I haz the power, 2013-10-02 05:33:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/25535006/11001

[commit-bot: I haz the power, 2013-10-02 08:20:23]

Change committed as 226435