Issue 25535005: Rename BrowserFrameAura to BrowserFrameAsh

Issue 25535005: Rename BrowserFrameAura to BrowserFrameAsh (Closed)

Created:
7 years, 2 months ago by pkotwicz

Modified:
7 years, 2 months ago

Reviewers:
James Cook, scottmg

CC:
chromium-reviews, tfarina, sadrul, dcheng, ben+watch_chromium.org, ananta, cpu_(ooo_6.6-7.5), sky

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename BrowserFrameAura to BrowserFrameAsh. This removes some previously needed ifdefs in BrowserFrameAura. BUG=None TEST=None R=jamescook TBR=sky (For comment changes) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226927

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Rebased #

Total comments: 1

Patch Set 4 : Nit as per jamescook@ #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -323 lines)			Patch
M	ash/wm/workspace/workspace_layout_manager_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame.cc	View	1 2 3	2 chunks	+13 lines, -0 lines	1 comment	Download
A +	chrome/browser/ui/views/frame/browser_frame_ash.h	View		4 chunks	+10 lines, -10 lines	0 comments	Download
A +	chrome/browser/ui/views/frame/browser_frame_ash.cc	View	1 2 3	6 chunks	+25 lines, -48 lines	0 comments	Download
D	chrome/browser/ui/views/frame/browser_frame_aura.h	View		1 chunk	+0 lines, -59 lines	0 comments	Download
D	chrome/browser/ui/views/frame/browser_frame_aura.cc	View	1 2	1 chunk	+0 lines, -184 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame_win.cc	View	1 2 3	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/frame/native_browser_frame_factory_aura.cc	View		2 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

pkotwicz

James, can you please take a look? I will clean up BrowserFrameAsh::WindowPropertyWatcher in an upcoming ...

7 years, 2 months ago (2013-10-02 03:30:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/25535005/2001

7 years, 2 months ago (2013-10-02 19:53:25 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 2 months ago (2013-10-02 20:45:41 UTC) #4

pkotwicz

James, can you please take another look? I moved the implementation of BrowserFrame::GetTitleFont() out of ...

7 years, 2 months ago (2013-10-03 21:23:03 UTC) #5

James Cook

LGTM with nit https://codereview.chromium.org/25535005/diff/79001/chrome/browser/ui/views/frame/browser_frame_ash.cc File chrome/browser/ui/views/frame/browser_frame_ash.cc (right): https://codereview.chromium.org/25535005/diff/79001/chrome/browser/ui/views/frame/browser_frame_ash.cc#newcode13 chrome/browser/ui/views/frame/browser_frame_ash.cc:13: #include "ui/gfx/font.h" You might not need ...

7 years, 2 months ago (2013-10-03 22:14:57 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/25535005/84001

7 years, 2 months ago (2013-10-03 22:40:07 UTC) #7

scottmg

https://codereview.chromium.org/25535005/diff/84001/chrome/browser/ui/views/frame/browser_frame.cc File chrome/browser/ui/views/frame/browser_frame.cc (right): https://codereview.chromium.org/25535005/diff/84001/chrome/browser/ui/views/frame/browser_frame.cc#newcode37 chrome/browser/ui/views/frame/browser_frame.cc:37: #include "ui/views/widget/native_widget_win.cc" Is this really supposed to be .cc?? ...

7 years, 2 months ago (2013-10-04 22:44:56 UTC) #9

scottmg

7 years, 2 months ago (2013-10-04 22:51:32 UTC) #10

Message was sent while issue was closed.

On 2013/10/04 22:44:56, scottmg wrote:
>
https://codereview.chromium.org/25535005/diff/84001/chrome/browser/ui/views/f...
> File chrome/browser/ui/views/frame/browser_frame.cc (right):
> 
>
https://codereview.chromium.org/25535005/diff/84001/chrome/browser/ui/views/f...
> chrome/browser/ui/views/frame/browser_frame.cc:37: #include
> "ui/views/widget/native_widget_win.cc"
> Is this really supposed to be .cc?? This breaks the non-Aura Windows build.

https://codereview.chromium.org/26054002/

Expand Messages | Collapse Messages