third_party/WebKit/Source/core/timing/PerformanceTest.cpp - Issue 2553493003: Add more detail to same-origin attribution indicating self|ancestor|descendant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceTest.cpp

Issue 2553493003: Add more detail to same-origin attribution indicating self|ancestor|descendant (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/timing/PerformanceTest.cpp

diff --git a/third_party/WebKit/Source/core/timing/PerformanceTest.cpp b/third_party/WebKit/Source/core/timing/PerformanceTest.cpp

index 7a07e9d0537c65face1716bd1902d497815666ab..9d6d960ac23c91a360ec1f8193a7bc8074abd345 100644

--- a/third_party/WebKit/Source/core/timing/PerformanceTest.cpp

+++ b/third_party/WebKit/Source/core/timing/PerformanceTest.cpp

@@ -81,7 +81,8 @@ TEST_F(PerformanceTest, SanitizedLongTaskName) {

EXPECT_EQ("unknown", sanitizedAttribution(nullptr, false, frame()));

// Attribute for same context (and same origin).

- EXPECT_EQ("same-origin", sanitizedAttribution(document(), false, frame()));

+ EXPECT_EQ("same-origin-self",

skobes 2016/12/05 22:00:51 Is it possible to test the other values?

+ sanitizedAttribution(document(), false, frame()));

// Unable to attribute, when multiple script execution contents are involved.

EXPECT_EQ("multiple-contexts",

« no previous file with comments | « third_party/WebKit/Source/core/timing/Performance.cpp ('k') | no next file » | no next file with comments »