Add more detail to same-origin attribution indicating self|ancestor|descendant

Add more detail to same-origin attribution indicating self|ancestor|descendant

BUG=667581
Committed: https://crrev.com/d3b8ed604c3fcbf470c11e888f4763afb5eb3b2f
Cr-Commit-Position: refs/heads/master@{#436539}

[panicker, 2016-12-05 21:55:25]

panicker@chromium.org changed reviewers:
+ caseq@chromium.org, skobes@chromium.org

[panicker, 2016-12-05 21:55:25]

PTAL

[skobes, 2016-12-05 22:00:51]

https://codereview.chromium.org/2553493003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceTest.cpp (right):

https://codereview.chromium.org/2553493003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceTest.cpp:84:
EXPECT_EQ("same-origin-self",
Is it possible to test the other values?

[panicker, 2016-12-05 22:58:17]

On 2016/12/05 22:00:51, skobes wrote:
>
https://codereview.chromium.org/2553493003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/timing/PerformanceTest.cpp (right):
> 
>
https://codereview.chromium.org/2553493003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/timing/PerformanceTest.cpp:84:
> EXPECT_EQ("same-origin-self",
> Is it possible to test the other values?
I haven't found a way to make frame trees in unittests. We had this conversation
in https://codereview.chromium.org/2381163003/#msg5 :)
I am actively working on crbug.com/671367 to address this with layout tests
which blocks the launch of Long Tasks (crbug.com/635596)

[skobes, 2016-12-05 23:00:35]

lgtm

On 2016/12/05 22:58:17, panicker wrote:
> On 2016/12/05 22:00:51, skobes wrote:
> > Is it possible to test the other values?
> I haven't found a way to make frame trees in unittests. We had this
conversation
> in https://codereview.chromium.org/2381163003/#msg5 :)

Right... sorry, I forgot :)

> I am actively working on crbug.com/671367 to address this with layout tests
> which blocks the launch of Long Tasks (crbug.com/635596)

[panicker, 2016-12-06 01:05:41]

The CQ bit was checked by panicker@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 01:06:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 02:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 02:34:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[panicker, 2016-12-06 04:09:58]

The CQ bit was checked by panicker@chromium.org

[panicker, 2016-12-06 04:09:58]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2553493003/#ps20001
(title: "update layout test")

[commit-bot: I haz the power, 2016-12-06 04:10:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 05:46:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480997398556820,
"parent_rev": "6f32087d69944b4dd8663e10bf1f048c4b7857af", "commit_rev":
"d7bc9fd7fc352700925d930a65724d1d57a577c5"}

[commit-bot: I haz the power, 2016-12-06 05:47:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-06 05:49:50]

Description was changed from

==========
Add more detail to same-origin attribution indicating self|ancestor|descendant

BUG=667581
==========

to

==========
Add more detail to same-origin attribution indicating self|ancestor|descendant

BUG=667581

Committed: https://crrev.com/d3b8ed604c3fcbf470c11e888f4763afb5eb3b2f
Cr-Commit-Position: refs/heads/master@{#436539}
==========

[commit-bot: I haz the power, 2016-12-06 05:49:51]

Patchset 2 (id:??) landed as
https://crrev.com/d3b8ed604c3fcbf470c11e888f4763afb5eb3b2f
Cr-Commit-Position: refs/heads/master@{#436539}