Issue 2553463002: Allow navigation while a JavaScript dialog is up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2553463002: Allow navigation while a JavaScript dialog is up. (Closed)

Created:
4 years ago by Avi (use Gerrit)

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Allow navigation while a JavaScript dialog is up. (It will cancel the dialog.) BUG=669996 TEST=as in bug Review-Url: https://codereview.chromium.org/2541173003 Cr-Commit-Position: refs/heads/master@{#435963} (cherry picked from commit 24a1bf068b07d183d456afdb8629e851467829c3) Committed: https://chromium.googlesource.com/chromium/src/+/224e73fccf2bace546537af107f432a4725eaf50

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -3 lines)			Patch
A	chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc	View	1 chunk	+42 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc	View	4 chunks	+30 lines, -3 lines	0 comments	Download
M	chrome/test/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Avi (use Gerrit)

4 years ago (2016-12-03 20:25:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
224e73fccf2bace546537af107f432a4725eaf50 (tree was closed).