src/arm64/lithium-codegen-arm64.cc - Issue 255343004: ARM64: Use default-NaN mode to canonicalize NaNs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/lithium-codegen-arm64.cc

Issue 255343004: ARM64: Use default-NaN mode to canonicalize NaNs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Reset FPCR for cctest/test-assembler-a64.cc. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/lithium-codegen-arm64.cc

diff --git a/src/arm64/lithium-codegen-arm64.cc b/src/arm64/lithium-codegen-arm64.cc

index 3ecd2403ba3b6aa0848006d90439a11b746e0bc3..10e0f080a4a6570f6ac897b798c777aab1b23934 100644

--- a/src/arm64/lithium-codegen-arm64.cc

+++ b/src/arm64/lithium-codegen-arm64.cc

@@ -5100,11 +5100,8 @@ void LCodeGen::DoStoreKeyedFixedDouble(LStoreKeyedFixedDouble* instr) {

}

if (instr->NeedsCanonicalization()) {

- DoubleRegister dbl_scratch = double_scratch();

- __ Fmov(dbl_scratch,

- FixedDoubleArray::canonical_not_the_hole_nan_as_double());

- __ Fmaxnm(dbl_scratch, dbl_scratch, value);

- __ Str(dbl_scratch, FieldMemOperand(store_base, offset));

+ __ CanonicalizeNaN(double_scratch(), value);

+ __ Str(double_scratch(), FieldMemOperand(store_base, offset));

} else {

__ Str(value, FieldMemOperand(store_base, offset));

}