Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2553383002: Mechanical style fixes: History.cpp and Location.cpp (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mechanical style fixes: History.cpp and Location.cpp This patch fixes some style errors caused at the Blink style change, and some long living other style nits. BUG=670237 Committed: https://crrev.com/52cfbdee4d6c72e941cb316ae9e1d5cc8301b2a4 Cr-Commit-Position: refs/heads/master@{#437487}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M third_party/WebKit/Source/core/frame/History.h View 1 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Source/core/frame/History.cpp View 1 3 chunks +6 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/frame/Location.cpp View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Takashi Toyoshima
Can you take a look this non-functional change? I notice some of them cause style ...
4 years ago (2016-12-09 04:48:04 UTC) #4
Takashi Toyoshima
4 years ago (2016-12-09 04:48:13 UTC) #5
tkent
lgtm
4 years ago (2016-12-09 05:15:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553383002/20001
4 years ago (2016-12-09 05:32:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 06:59:12 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-09 07:01:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/52cfbdee4d6c72e941cb316ae9e1d5cc8301b2a4
Cr-Commit-Position: refs/heads/master@{#437487}

Powered by Google App Engine
This is Rietveld 408576698