third_party/WebKit/Source/core/dom/IntersectionObservation.cpp - Issue 2553343004: IntersectionObserver: use nullptr for implicit root.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

Issue 2553343004: IntersectionObserver: use nullptr for implicit root. (Closed)

Patch Set: similarity=30 to detect renames Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

index 724c4312e55bd32fe530d9023a8e2c4d92af009c..051e8b1055ff2b01e45d89f765d8d9da7118dced 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

@@ -27,10 +27,8 @@ void IntersectionObservation::computeIntersectionObservations(

rootMargin[1] = m_observer->rightMargin();

rootMargin[2] = m_observer->bottomMargin();

rootMargin[3] = m_observer->leftMargin();

- Node* rootNode = m_observer->rootNode();

- IntersectionGeometry geometry(

- rootNode && !rootNode->isDocumentNode() ? toElement(rootNode) : nullptr,

- *target(), rootMargin, m_shouldReportRootBounds);

+ IntersectionGeometry geometry(m_observer->root(), *target(), rootMargin,

+ m_shouldReportRootBounds);

geometry.computeGeometry();

// Some corner cases for threshold index: