third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp - Issue 2553343004: IntersectionObserver: use nullptr for implicit root.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

Issue 2553343004: IntersectionObserver: use nullptr for implicit root. (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObserver.cpp ('k') | third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp b/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

index d0888bc33b42b649732eea215d9a7386cf034955..b7550390b78fb00a758f10e1cbd841007c2c6b02 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

@@ -5,6 +5,7 @@

#include "core/dom/IntersectionObserverController.h"

#include "core/dom/Document.h"

+#include "core/dom/Element.h"

#include "core/dom/TaskRunnerHelper.h"

#include "platform/tracing/TraceEvent.h"

@@ -86,7 +87,7 @@ void IntersectionObserverController::removeTrackedObserversForRoot(

const Node& root) {

HeapVector<Member<IntersectionObserver>> toRemove;

for (auto& observer : m_trackedIntersectionObservers) {

- if (observer->rootNode() == &root)

+ if (observer->root() == &root)

toRemove.append(observer);

}

m_trackedIntersectionObservers.removeAll(toRemove);