Issue 255333004: Harden more runtime functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255333004: Harden more runtime functions (Closed)

Created:
6 years, 7 months ago by Jakob Kummerow

Modified:
6 years, 7 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Harden more runtime functions R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21090

Patch Set 2 : address comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -18 lines)			Patch
M	src/objects.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View		1 chunk	+9 lines, -4 lines	0 comments	Download
M	src/runtime.h	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1	17 chunks	+51 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

lgtm with a nit. https://codereview.chromium.org/255333004/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/255333004/diff/1/src/runtime.cc#newcode961 src/runtime.cc:961: RUNTIME_ASSERT(arrayId >= 1 && arrayId ...

6 years, 7 months ago (2014-04-30 13:09:15 UTC) #2

Jakob Kummerow

Thanks, landing. https://codereview.chromium.org/255333004/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/255333004/diff/1/src/runtime.cc#newcode961 src/runtime.cc:961: RUNTIME_ASSERT(arrayId >= 1 && arrayId <= 9); ...

6 years, 7 months ago (2014-04-30 13:15:35 UTC) #3

Jakob Kummerow

6 years, 7 months ago (2014-04-30 13:19:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21090 (presubmit successful).

Expand Messages | Collapse Messages

Issue 255333004: Harden more runtime functions (Closed)

Description

Patch Set 1 #

Patch Set 2 : address comments #

Messages