Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 25533005: Eliminate usage of content url constants in Autofill core code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add reference to bug Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 4b2afb1590ceea5d4d34c5956d21d2da6fc36b06..def1a100ad05b142ca676bf671b586d6e1601aae 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -47,7 +47,6 @@
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/common/url_constants.h"
#include "grit/component_strings.h"
#include "third_party/WebKit/public/web/WebAutofillClient.h"
#include "ui/base/l10n/l10n_util.h"
@@ -126,7 +125,9 @@ bool SectionIsAutofilled(const FormStructure& form_structure,
}
bool FormIsHTTPS(const FormStructure& form) {
- return form.source_url().SchemeIs(content::kHttpsScheme);
+ // TODO(blundell): Change this to use a constant once crbug.com/306258 is
+ // fixed.
+ return form.source_url().SchemeIs("https");
}
// Uses the existing personal data in |profiles| and |credit_cards| to determine
« no previous file with comments | « components/autofill/core/browser/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698