Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2553273002: Fuchsia: Make targets including the observatory in the standlone VM available. (Closed)

Created:
4 years ago by zra
Modified:
4 years ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Make targets including the observatory in the standlone VM available. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/6f0b59b5084a9c61eae1eadee4ebcf2e8fe47665

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -29 lines) Patch
M runtime/bin/BUILD.gn View 1 chunk +27 lines, -29 lines 0 comments Download
M runtime/observatory/BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
4 years ago (2016-12-06 22:37:06 UTC) #3
siva
lgtm https://codereview.chromium.org/2553273002/diff/1/runtime/observatory/BUILD.gn File runtime/observatory/BUILD.gn (right): https://codereview.chromium.org/2553273002/diff/1/runtime/observatory/BUILD.gn#newcode27 runtime/observatory/BUILD.gn:27: } What is this for? Can you add ...
4 years ago (2016-12-06 23:24:39 UTC) #4
zra
https://codereview.chromium.org/2553273002/diff/1/runtime/observatory/BUILD.gn File runtime/observatory/BUILD.gn (right): https://codereview.chromium.org/2553273002/diff/1/runtime/observatory/BUILD.gn#newcode27 runtime/observatory/BUILD.gn:27: } On 2016/12/06 23:24:39, siva wrote: > What is ...
4 years ago (2016-12-07 19:11:23 UTC) #5
zra
4 years ago (2016-12-07 19:12:08 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6f0b59b5084a9c61eae1eadee4ebcf2e8fe47665 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698