Source/platform/fonts/mac/ComplexTextController.cpp - Issue 255323004: Rendering text-justify:distribute for 8 bit characters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/mac/ComplexTextController.cpp

Issue 255323004: Rendering text-justify:distribute for 8 bit characters. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Using 2 bits for enum Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/mac/ComplexTextController.cpp

diff --git a/Source/platform/fonts/mac/ComplexTextController.cpp b/Source/platform/fonts/mac/ComplexTextController.cpp

index 652835589dc2f9131852360900bcb620b9476a69..49fa0e8e84645e166943bada2a5ae8f17a239224 100644

--- a/Source/platform/fonts/mac/ComplexTextController.cpp

+++ b/Source/platform/fonts/mac/ComplexTextController.cpp

@@ -68,9 +68,9 @@ ComplexTextController::ComplexTextController(const Font* font, const TextRun& ru

bool isAfterExpansion = m_afterExpansion;

unsigned expansionOpportunityCount;

if (m_run.is8Bit())

- expansionOpportunityCount = Character::expansionOpportunityCount(m_run.characters8(), m_end, m_run.direction(), isAfterExpansion);

+ expansionOpportunityCount = Character::expansionOpportunityCount(m_run.characters8(), m_end, m_run.direction(), isAfterExpansion, m_run.textJustify());

else

- expansionOpportunityCount = Character::expansionOpportunityCount(m_run.characters16(), m_end, m_run.direction(), isAfterExpansion);

+ expansionOpportunityCount = Character::expansionOpportunityCount(m_run.characters16(), m_end, m_run.direction(), isAfterExpansion, m_run.textJustify());

if (isAfterExpansion && !m_run.allowsTrailingExpansion())

expansionOpportunityCount--;

« Source/platform/fonts/Character.cpp ('K') | « Source/platform/fonts/WidthIterator.cpp ('k') | Source/platform/text/TextRun.h » ('j') | Source/platform/text/TextRun.h » ('J')