Source/platform/text/TextRun.cpp - Issue 255323004: Rendering text-justify:distribute for 8 bit characters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/text/TextRun.cpp

Issue 255323004: Rendering text-justify:distribute for 8 bit characters. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Using enum Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/text/TextRun.cpp

diff --git a/Source/platform/text/TextRun.cpp b/Source/platform/text/TextRun.cpp

index 2cad6468cd5b6777449da780b7dae46490ea4eb9..1671b9b37c9bb99d8c7e43b29a937be84ee27553 100644

--- a/Source/platform/text/TextRun.cpp

+++ b/Source/platform/text/TextRun.cpp

@@ -37,6 +37,7 @@ struct ExpectedTextRunSize {

uint32_t bitfields : 10;

leviw_travelin_and_unemployed 2014/08/11 17:34:46 It looks like we're only actually using 8 right no

dw.im 2014/08/12 02:47:09 If we pack m_textJustify into two bits, it become

unsigned anUnsigned;

RefPtr<TextRun::RenderingContext> renderingContext;

+ ETextJustify m_textJustify;

};

COMPILE_ASSERT(sizeof(TextRun) == sizeof(ExpectedTextRunSize), TextRun_is_not_of_expected_size);

« Source/platform/text/TextRun.h ('K') | « Source/platform/text/TextRun.h ('k') | no next file » | no next file with comments »